-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content flag category selection #1513
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts for now -- I didn't get a chance to test this yet but the code is looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming along nicely! Thanks for the name updates and for using the new #Preview
!
|
||
var body: some View { | ||
HStack(alignment: .center) { | ||
VStack(alignment: .leading, spacing: 8) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the Spam one isn't quite centered vertically and needs to move down a bit -- probably because there's no description for it. I can't tell what we'd need to do to fix that just by looking, but I'd be happy to help debug if you'd like.
Issues covered
Part 2 of #1498
Part 1 of #1489
Description
This PR starts work on the new content flag flow. It includes the following changes:
NosRadioButton
component.FlagOptionPicker
component.ContentFlagView
component.ReportMenuModifier
to show either the old menu or new menu based on thenewModerationFlow
feature flag boolean.How to test
Flag this content
option.Screenshots/Video
Before:
Screen.Recording.2024-09-17.at.2.56.12.PM.mov
After:
Screen.Recording.2024-09-17.at.2.56.31.PM.mov