Add content flag assets and strings #1512
Conversation
pelumy
requested review from
mplorentz,
martindsq and
joshuatbrown
as code owners
Nos/Models/FlagOption.swift
Outdated
| let description: String? | ||
| var id: String { title } | ||
|
|
||
| // `FlagOption` instances representing different categories of content that can be flagged. |
There was a problem hiding this comment.
| // `FlagOption` instances representing different categories of content that can be flagged. | |
| /// `FlagOption` instances representing different categories of content that can be flagged. |
If you make this a triple-slash (HeaderDoc comment) it will show up in the documentation pane (right hand pane of Xcode) or when this variable is option-clicked!
There was a problem hiding this comment.
Thank you for catching these @mplorentz
There was a problem hiding this comment.
I suggest renaming this radio-button-selected-bottom (and the other radio-button-selected-top).
| @@ -5054,6 +5054,28 @@ | |||
| } | |||
| } | |||
| }, | |||
| "harassmentFlagContentDescription" : { | |||
There was a problem hiding this comment.
I think I'd switch the words around a bit, so all of them are sorted together in the file. So this one would be:
| "harassmentFlagContentDescription" : { | |
| "flagContentHarassmentDescription" : { |
And then all the others would be similar, starting with flagContent and then the type and then Title or Description at the end.
| "en" : { | ||
| "stringUnit" : { | ||
| "state" : "translated", | ||
| "value" : "Others" |
There was a problem hiding this comment.
| "value" : "Others" | |
| "value" : "Other" |
|
Thanks for the naming suggestions @joshuatbrown. Honestly, I was a lil bit confused about the naming 😸. I will implement these suggestions. |
pelumy
force-pushed
the
content-flag-assets-and-strings
branch
from
ac2ac82
to
693f7f3
Compare
# Conflicts: # Nos.xcodeproj/project.pbxproj
Issues covered
Part 1 of #1498
Description
This PR adds new colors, localised strings and a model required to display the UI of the first flow of the new moderation flow.