Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SwiftSoup to parse Open Graph metadata #1505

Merged
merged 13 commits into from
Sep 17, 2024
Merged

Use SwiftSoup to parse Open Graph metadata #1505

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ae23b89
start defining Open Graph fetching and parsing API
joshuatbrown Sep 12, 2024
44f5307
test for video height, too
joshuatbrown Sep 12, 2024
96d3d67
parse open graph metadata with SwiftSoup
joshuatbrown Sep 13, 2024
d9cf503
fix a bug in open graph tests
joshuatbrown Sep 13, 2024
0d284f9
Merge branch 'open-graph/base' into open-graph/swiftsoup
joshuatbrown Sep 13, 2024
d1d82fd
refactor Soup parser to be much nicer
joshuatbrown Sep 16, 2024
fd985c9
add documentation to SoupOpenGraphParser
joshuatbrown Sep 16, 2024
a44cf5f
Update doc comments; remove unneeded property
joshuatbrown Sep 16, 2024
8537420
Merge branch 'open-graph/base' into open-graph/swiftsoup
joshuatbrown Sep 16, 2024
777c273
fix build error
joshuatbrown Sep 16, 2024
ce1df96
Merge branch 'main' into open-graph/swiftsoup
joshuatbrown Sep 17, 2024
fa5f683
update CHANGELOG
joshuatbrown Sep 17, 2024
fc174cc
refactor and clean up Open Graph parser
joshuatbrown Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix a bug in open graph tests
  • Loading branch information
@joshuatbrown
joshuatbrown committed Sep 13, 2024
commit d9cf503bec670851ae756cfec2f5abc16011de0a
2 changes: 1 addition & 1 deletion NosTests/Service/Media/OpenGraphParserTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ class OpenGraphParserTests: XCTestCase {

// Assert
XCTAssertEqual(videoMetadata.width, 1280)
XCTAssertEqual(videoMetadata.width, 720)
XCTAssertEqual(videoMetadata.height, 720)
}
}
Loading