Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start defining Open Graph fetching and parsing API #1503

Closed
wants to merge 4 commits into from
Closed

start defining Open Graph fetching and parsing API #1503

wants to merge 4 commits into from

Conversation

joshuatbrown
Copy link
Contributor

Issues covered

#1165

Description

The API for fetching and parsing Open Graph metadata.

How to test

Run the unit tests. They fail, because nothing is implemented in this PR. Look out for future PRs where it's actually implemented.

@joshuatbrown joshuatbrown mentioned this pull request Sep 12, 2024
Closed
@joshuatbrown joshuatbrown mentioned this pull request Sep 13, 2024
Merged
@joshuatbrown
Copy link
Contributor Author

We're going with #1505, so I'm closing this and merging that to main.

@joshuatbrown joshuatbrown deleted the open-graph/base branch September 19, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mplorentz mplorentz Awaiting requested review from mplorentz mplorentz will be requested when the pull request is marked ready for review mplorentz is a code owner

@martindsq martindsq Awaiting requested review from martindsq martindsq will be requested when the pull request is marked ready for review martindsq is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joshuatbrown