-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add share note functionality #1477
Conversation
I'm curious as to why this note link directs the user to an njump website instead of the nos app 🤔 |
@pelumy I think the main reason is compatibility -- we don't know the people who receive the link have Nos installed, and since we're using TestFlight right now, it's a little challenging for some people to get it installed. The njump link will work for anyone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works perfectly! Weird but cool that we already had the showingShare
property and sheet ready for you! Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Perfect!
Issues covered
#1272
Description
This PR adds a share functionality to the share note button option on the confirmation dialogue in the
NoteOptionsButton
file. The following changes were made:showingShare
state variable was already present, so set it totrue
when the share note button is pressed.ActivityViewController
to perform actions after the share activity is finished.showingShare
tofalse
in this completion handler to dismiss the share sheet after the share activity is finished.How to test
Screenshots/Video
Screen.Recording.2024-09-09.at.4.09.45.PM.mov