fixed issue where relay metadata is never updated #1472 #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmontz
requested review from
mplorentz,
martindsq and
joshuatbrown
as code owners
joshuatbrown
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#1472
Description
Faulty date logic prevented relay metadata from ever being updated after the initial time. The check in
RelayService.queryRelayMetadataIfNeeded(_:)was backwards and resulted in a negative number for the time interval, failing the check every time.How to test
The issue and the fix are not readily observable from the UI. However, a developer can add log statements to confirm the issue and the fix for it.
Before (from the ticket):
The breakpoint is never hit, even though some of the relays' metadata is two weeks old.
After:
The breakpoint is hit (and metadata will be updated) when the code encounters the first relay whose metadata is over 3 days old: