truncated text is expanding out due to not fixing the size of the view #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedbrosby
requested review from
mplorentz,
martindsq and
joshuatbrown
as code owners
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
bryanmontz
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
Thanks, @tedbrosby! I confirmed that this resolves the issue.
joshuatbrown
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Thank you so much for the contribution, @tedbrosby! This works perfectly for me!
…by/nos into quoted-notes-rendered-off-screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#1463: Some quoted notes are rendered offscreen
Description
Hi Nos team!
I noticed this issue and spent an hour or so diagnosing it. Unfortunately the CompactNoteView only has a single unit test. But I realized none of the preview data includes a quoted reference with the referenced note having long text and a wide image.
I tried to replicate it but I think my contextual knowledge of note references is lacking.
Either way, I hope this PR saves you some time.
How to test
8f95884af2646903601b2bf1d535f849a1fd1adcf4b57bc1c49b9a42efc2f94fScreenshots/Video