Add "Display" to the Name textfield header on the edit profile page.

[pelumy]

Issues covered

#1445

Description

This PR updates "Name" to "Display Name" in the EditProfile page

• The value of the displayName key was capitalised in the Localizable file
• The localized displayName key is used to replace the previous localized name key

How to test

1. Build the code
2. Tap the Profile tab on the bottom right
3. Tap the Edit Profile button on the page
4. Please check that under the Basic Information category, the "Name" header has been changed to "Display Name".

Screenshots/Video

Before	After

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[pelumy]

I have read the CLA Document and I hereby sign the CLA

[mplorentz]

This perfectly does what is asked for in the ticket, but I think the ticket description left something out.

The data for a Nostr profile is stored in a "metadata" event, and there are two name fields in the metadata event: name and display_name. These are mapped to the properties on our Author class called name and displayName. Since we changed the label in the UI I think we also need to change the code that saves the name to use author.displayName instead of author.name. It looks like you can do this in ProfileEditView.save().

You weren't expected to figure this out on your own, I just happened to notice it while reviewing. Can you make that change and then request another review?

[pelumy]

This perfectly does what is asked for in the ticket, but I think the ticket description left something out.

The data for a Nostr profile is stored in a "metadata" event, and there are two name fields in the metadata event: name and display_name. These are mapped to the properties on our Author class called name and displayName. Since we changed the label in the UI I think we also need to change the code that saves the name to use author.displayName instead of author.name. It looks like you can do this in ProfileEditView.save().

You weren't expected to figure this out on your own, I just happened to notice it while reviewing. Can you make that change and then request another review?

Thanks for pointing this out Matt. I have a few questions:|

• Does this also mean we would change the @state var name from name to displayName?
• Also, why don't we have two different textfields for name and displayName, if we have both in the Author metadata?

[mplorentz]

Hey @pelumy, this looks good and accomplishes what I asked for in my last comment. However I found one weird flow on my test account that I would like to smooth out before we merge. It looks like if the user has only set a name in Nos but never a displayName then we actually show an empty displayName field. I think this is happening because we have been saving an empty string into the displayName field, so this line of code ends up evaulating as displayNameText = "". It looks a little weird:

Screen.Recording.2024-09-05.at.3.43.52.PM.mov

Can you tweak this so that it uses the name if author.displayName is nil or empty?

[pelumy]

Ooh, thanks for catching this @mplorentz . I will push a fix for this.

[pelumy]

@mplorentz , I have pushed the fix and the video below shows:

First screen, a new test account with only name set
After new build, the new test account with the empty display name
After new build, the new test account with the name displayed under the display name.
https://github.com/user-attachments/assets/f073f444-4266-4930-8f36-2e0e79532f95

I also made sure to test that the displayName still shows for accounts that already saved the displayName.

[mplorentz]

This is good to go now. Nice work @pelumy!

[joshuatbrown]

@pelumy awesome work on your first PR -- this is great!

[pelumy]

Thank you @joshuatbrown 😊