Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace relay.snort.social with nos.lol #1439

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

mplorentz
Copy link
Member

@mplorentz mplorentz commented Aug 28, 2024

Issues covered

#1427

Description

Replaces relay.snort.social with nos.lol in our default relay list

How to test

  • Create a fresh account and verify that the relay list looks correct
  • Remove nos.lol from your relay list and make sure it shows up in the "recommended" section.

Copy link
Contributor

@joshuatbrown joshuatbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works well and I'm good with merging, but I'd love to have one little change.

@@ -15,8 +15,7 @@ public class Relay: NosManagedObject {
"wss://relay.damus.io",
"wss://purplepag.es",
nosAddress.absoluteString,
"wss://relay.snort.social",
"wss://olympics2024.nos.social",
"wss://nos.lol",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good -- I was hoping we'd remove the olympics one soon since that's over. Also: it bothers me that nosAddress.absoluteString isn't first in the list. Would you mind updating that here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@mplorentz mplorentz added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 404d12a Aug 30, 2024
4 checks passed
@mplorentz mplorentz deleted the update-default-relays branch August 30, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants