Fixes alerts when uploading big files and suggests users subscribe to nostr.build

[rabble]

Issues covered

#1275

Description

Provides a better error message and gives the option to pay for nostr.build

How to test

1. Build the app.
2. Click the post button on the tab bar.
3. Click the gallery/file icon at the bottom left of the popup.
4. Upload a photo / video that is greater than 25mb.
5. Please check that the error message that shows up is about the exceeded file size, with two buttons, 1 to cancel and the other to purchase a premium nostr account plan. Clicking the "Get Account" button should take you to the pricing plan screen.

Screenshots/Video

Screen.Recording.2024-09-11.at.6.04.56.PM.mov

[mplorentz]

@rabble unfortunately that error message is usually a lie and is hiding the real error. Try commenting out some of your changes until you narrow down the line that is wrong. If that doesn't help maybe @joshuatbrown or I can take a look on Monday.

[joshuatbrown]

@rabble thanks for working on this! It's a really annoying bug.

[mplorentz]

Also we've picked up the habit as marking WIP PRs as "drafts" in Github. We'll still review them, but it's just an extra signal that it's not ready for merging yet. You can click the "convert to draft" button up by the reviewers to make this PR a draft.

[joshuatbrown]

In general, this looks great! It works exactly as expected, and it's super nice to have this message to tell people what's going on. In addition to my comment, I see a few SwiftLint errors to address, but this looks like it's really close.

[mplorentz]

Hey Rabble, this is close but there are a few things missing.

• Right now it will return the size error no matter what error we get back from the nostr.build API. So even if the user is offline or something it will tell them they hit the size limit. I think we'll want to make a new case in the FileStorageAPIClientError type that is like fileTooBig, and then when we get an error from nostr.build we should check to see if the error message is about the file size. We could check for the text "File size exceeds the limit" in the message. Search for the line throw FileStorageAPIClientError.uploadFailed(response.message) and replace it with something like if itLooksLIkeASizeError { throw fileTooBigError } else { throw uploadFailed }.
• There are some linting errors. You can see this locally if you brew install swiftlint
• Can you add a line to the top of the changelog?

[mplorentz]

There is also a bug I see that XCStringsTool isn't generating accessors for Nos/Assets/Localization/ImagePicker.xcstrings. I don't see a way to fix that in the docs. There isn't a configuration file that I see. @joshuatbrown do you know how to fix this off the top of your head? I know you tried removing XCStringsTool recently.

[rabble]

There is also a bug I see that XCStringsTool isn't generating accessors for Nos/Assets/Localization/ImagePicker.xcstrings. I don't see a way to fix that in the docs. There isn't a configuration file that I see. @joshuatbrown do you know how to fix this off the top of your head? I know you tried removing XCStringsTool recently.

Ah, i wasn't aware xcode had a way of editing those files visually... i was editing the json.. i've now tried opening the file from teh CLI and it shows an editor.... i added spanish too. Should be fixed..

I think it's ready for you guys to look at again.

[mplorentz]

Hey Rabble, I checked this out and fixed the linter errors for you. However I'm seeing one more bug. If I turn my internet off and try to upload a photo the resulting error message looks correct now the but the "Get Account" button is shown instead of "Ok".

One more request: can the "Get Account" button open https://nostr.build/plans instead of https://nostr.build?

[joshuatbrown]

This works perfectly and I'm glad we're looking for the HTTP 413! I just have some comments on how it's implemented, and I'd love to see a unit test or two. I have some ideas for how to do that, so I'm happy to help if needed.

[pelumy]

This works perfectly and I'm glad we're looking for the HTTP 413! I just have some comments on how it's implemented, and I'd love to see a unit test or two. I have some ideas for how to do that, so I'm happy to help if needed.

@joshuatbrown, this is something I have been looking forward to do. I would be happy to have a guide on the unit testing.

[joshuatbrown]

This works perfectly, and I love the updates! Everything looks great, though I'd love to see one very small tweak. Thanks!

[joshuatbrown]

Thanks for the update! This is perfect!

[pelumy]

Thanks for the update! This is perfect!

Thank you @joshuatbrown

[mplorentz]

Sorry I blocked the merge on this. Nice work!