Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Punctuation after a url breaks the url formatting #1233

Closed
setch-l opened this issue Jun 12, 2024 · 1 comment
Closed

[bug] Punctuation after a url breaks the url formatting #1233

setch-l opened this issue Jun 12, 2024 · 1 comment
Assignees
@bryanmontz
Labels
bug Something isn't working

Comments

@setch-l
Copy link

setch-l commented Jun 12, 2024

Steps to reproduce

  1. Write a text note and use nos.social or another url with punctuation at the end like: nos.social.
    Issue: We do not strip out the punctuation and as a result, the preview link is broken and there's a protocol error in the browser (for our site at least).
    Expected: If a user enters a period, comma, colon or semi-colon after a url then we should strip it out when generating the link and the link preview.

You can test this with this note: note1l4gf7095vkvylx4sn5u5t635y94jcwqlq4z33awc678lcm8zrktsyjjf3p

Image
@setch-l setch-l added the bug Something isn't working label Jun 12, 2024
bryanmontz added a commit that referenced this issue Aug 9, 2024
@bryanmontz
fix: urls with periods after them include the period and don't work a…
73393f5 
…s expected #1233
@bryanmontz bryanmontz mentioned this issue Aug 9, 2024
Merged
bryanmontz added a commit that referenced this issue Aug 10, 2024
@bryanmontz
fix: urls with periods after them include the period and don't work a…
2fb9451 
…s expected #1233
bryanmontz added a commit that referenced this issue Aug 12, 2024
@bryanmontz
fix: urls with periods after them include the period and don't work a…
4a7e33f 
…s expected #1233
github-merge-queue bot pushed a commit that referenced this issue Aug 12, 2024
@joshuatbrown
Merge pull request #1392 from planetary-social/bdm/1233
ca0b317 
fix: urls with periods after them include the period and don't work as expected #1233
@setch-l setch-l closed this as completed Aug 14, 2024
joshuatbrown added a commit that referenced this issue Aug 16, 2024
@joshuatbrown
Merge pull request #1392 from planetary-social/bdm/1233
7224235 
fix: urls with periods after them include the period and don't work as expected #1233
@joshuatbrown
Copy link
Contributor

@setch-l Reopening and putting into QA since this will be in the 0.1.25 build.

@joshuatbrown joshuatbrown reopened this Aug 16, 2024
@setch-l setch-l closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanmontz bryanmontz

Labels
bug Something isn't working
Projects
Nos Product Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshuatbrown @bryanmontz @setch-l