Skip to content

Commit

Permalink
Merge pull request #1678 from planetary-social/repost-crash-workaround
Browse files Browse the repository at this point in the history
Repost crash workaround
  • Loading branch information
mplorentz authored Oct 22, 2024
2 parents 09c54e5 + f46d722 commit 275a299
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Added the Account Success onboarding screen. Currently behind the “New Onboarding Flow” feature flag. [#1599](https://github.com/planetary-social/nos/issues/1599)
- Updated the Age Verification onboarding screen. Currently behind the “New Onboarding Flow” feature flag. [#1651](https://github.com/planetary-social/nos/issues/1651)
- Track opening mentions with Posthog. [#1480](https://github.com/planetary-social/nos/issues/1480)
- Avoid crash and print extra debugging details when a reposted note that has not finished loading is clicked. [#1669](https://github.com/planetary-social/nos/issues/1669)

## [0.2.2] - 2024-10-11Z

Expand Down
9 changes: 8 additions & 1 deletion Nos/Router.swift
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,14 @@ import Dependencies
)
)
} else {
fatalError("Tried to push a note with no identifier; that's not going to work.")
let debuggingDetails = """
noteId: \(String(describing: note.identifier)) \n
replaceableIdentifier: \(String(describing: note.replaceableIdentifier)) \n
noteAuthor: \(String(describing: note.author))
"""

crashReporting.report("Tried to push a note and it failed. Details: \n \(debuggingDetails)")
assertionFailure("Tried to push a note and it failed. Details: \n \(debuggingDetails)")
}
}

Expand Down

0 comments on commit 275a299

Please sign in to comment.