Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue that exiting to lobby with backspace in shop #971

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Fix issue that exiting to lobby with backspace in shop #971

merged 1 commit into from
Nov 18, 2021

Conversation

sonohoshi
Copy link
Member

Unengine
Unengine reviewed Nov 18, 2021
View reviewed changes
nekoyume/Assets/_Scripts/UI/Widget/ShopBuy.cs
@@ -145,6 +140,7 @@ private void Close()
_npc?.gameObject.SetActive(false);
shopItems.Close();
Find<ItemCountAndPricePopup>().Close();
Game.Event.OnRoomEnter.Invoke(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If don't invoke OnRoomEnter, screen will get blackout after closing this widget.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, OnRoomEnter was separated from Close, but I put it inside Close because I thought it was meaningless.

@sonohoshi sonohoshi added the bug Something isn't working label Nov 18, 2021
@sonohoshi sonohoshi requested a review from Unengine November 18, 2021 10:20
@sonohoshi sonohoshi merged commit 9ba293f into rc-v100087 Nov 18, 2021
@sonohoshi sonohoshi deleted the improve/input-backspace-in-shop branch December 1, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unengine Unengine Unengine approved these changes

@Namyujeong Namyujeong Namyujeong approved these changes

@boscohyun boscohyun Awaiting requested review from boscohyun

@hskim881028 hskim881028 Awaiting requested review from hskim881028

@ipdae ipdae Awaiting requested review from ipdae

Assignees

@sonohoshi sonohoshi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonohoshi @Unengine @Namyujeong