Apply changes for Thor planet #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
U-lis
commented
Nov 12, 2024
U-lis
commented
- Give 5 times more items
- Give 5 times more mileage
- No mileage products
- Images has special name for Thor chain
- github actions vars - CDK stack env. variables - Planet list - GQL URL list - Genesis hash list
Closed
ipdae
reviewed
Nov 13, 2024
| @@ -44,6 +44,10 @@ def product_list(agent_addr: str, | |||
| category_schema_list = [] | |||
| purchase_history = get_purchase_history(sess, planet_id, agent_addr) | |||
| for category in all_category_list: | |||
| # Do not show Mileage category for thor chain | |||
There was a problem hiding this comment.
토르 체인에서는 마일리지를 5배 쌓고, 이걸 체인이 종료된 후에 다른 체인으로 이동해주는 기획이 있습니다.
마일리지를 5배 주는 대신 여기에서 마일리지 상품을 못 사게 하자는 기획에 따라 Mileage category 를 가립니다.
| for x in product.fav_list]) | ||
| claim_list = [ | ||
| {"ticker": x.fungible_item_id, | ||
| "amount": x.amount * (5 if receipt.planet_id in (PlanetID.THOR, PlanetID.THOR_INTERNAL) else 1), |
There was a problem hiding this comment.
토르쪽 보정(*5)가 들어가는 코드가 많은데 아예 모델에 메서드를 만들고 그걸 쓰면 어떨까요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.