device: log and comment cosmetics

plan44 · Aug 1, 2023 · 6552e99 · 6552e99
1 parent f9044a6
commit 6552e99
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/devices/device.cpp b/src/devices/device.cpp
@@ -222,6 +222,7 @@ EmberAfStatus Device::HandleReadAttribute(ClusterId clusterId, chip::AttributeId
     OLOG(LOG_WARNING, "****** tried to access basic infomation cluster *****");
   }
   else if (clusterId==BridgedDeviceBasicInformation::Id) {
+    // Reachable flag
     if (attributeId == BridgedDeviceBasicInformation::Attributes::Reachable::Id) {
       return getAttr(buffer, maxReadLength, mDeviceInfoDelegate.isReachable());
     }

diff --git a/src/devices/devicelevelcontrol.cpp b/src/devices/devicelevelcontrol.cpp
@@ -86,7 +86,7 @@ bool DeviceLevelControl::updateCurrentLevel(uint8_t aAmount, int8_t aDirection,
   if (level<minlevel) level = minlevel;
   // now move to given or calculated level
   if (level!=mLevel || aUpdateMode.Has(UpdateFlags::forced)) {
-    OLOG(LOG_INFO, "setting level to %d in %d00mS - %supdatemode=0x%x", aAmount, aTransitionTimeDs, aWithOnOff ? "WITH OnOff, " : "", aUpdateMode.Raw());
+    OLOG(LOG_INFO, "setting level to %d (clipping to %d..%d) in %d00mS - %supdatemode=0x%x", aAmount, minlevel, maxlevel, aTransitionTimeDs, aWithOnOff ? "WITH OnOff, " : "", aUpdateMode.Raw());
     uint8_t previousLevel = mLevel;
     if ((previousLevel<=minlevel || aUpdateMode.Has(UpdateFlags::forced)) && level>minlevel) {
       // level is minimum and becomes non-minimum: also set OnOff when enabled