Added logic for request timeouts #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelckelly
requested review from
joyzheng and
r-ohan
and removed request for
joyzheng
r-ohan
suggested changes
May 4, 2017
Contributor
r-ohan
left a comment
r-ohan
left a comment
There was a problem hiding this comment.
Your changes look good, I left some minor comments about formatting. Thanks for submitting this!
plaid/requester.py
Outdated
|
|
||
| ALLOWED_METHODS = {'post'} | ||
| TIMEOUT = 600 # 10 minutes | ||
| DEFAULT_TIMEOUT = 600 # 10 minutes |
Contributor
There was a problem hiding this comment.
Could you make this two spaces between 600 and the comment? (PEP 8)
plaid/client.py
Outdated
| return post_request( | ||
| urljoin('https://' + self.environment + '.plaid.com', path), | ||
| data=data, | ||
| data=data, timeout=self.timeout |
Contributor
There was a problem hiding this comment.
Could you please put timeout=self.timeout on a new line?
Contributor
Author
|
okay, I have made the requested updates |
r-ohan
approved these changes
May 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Many of the newer institutions (especially for Auth and Identity) take several minutes to receive a response. It would be ideal for anyone consuming this API to be able to set a timeout as they would for any other request.
This PR adds a
timeoutargument to the Client() object; all API requests are then limited to the specified timeout, else aReadTimeoutErroris raised.