Skip to content

Include request_id field on PlaidError class #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joyzheng merged 2 commits into from
Apr 16, 2018
Merged

Include request_id field on PlaidError class #119

joyzheng merged 2 commits into from
Apr 16, 2018

Conversation

@joyzheng
Copy link
Contributor

@joyzheng joyzheng commented Apr 12, 2018

No description provided.

@joyzheng joyzheng requested a review from r-ohan April 12, 2018 19:01
r-ohan
r-ohan approved these changes Apr 14, 2018
View reviewed changes
Copy link
Contributor

@r-ohan r-ohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@joyzheng
Copy link
Contributor Author

joyzheng commented Apr 16, 2018

I realized that adding request_id to the PlaidError initializer would be a breaking change, so adjusted to give it a default value of "".

@r-ohan
Copy link
Contributor

r-ohan commented Apr 16, 2018

good catch. new changes look good.

@joyzheng joyzheng merged commit 1f8ed9d into master Apr 16, 2018
@joyzheng joyzheng deleted the jz-requestid branch April 16, 2018 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@r-ohan r-ohan r-ohan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joyzheng @r-ohan @jzheng-plaid