add /sandbox/public_token/create #154
Conversation
| initialProducts: Array<string>, | ||
| options: Object, | ||
| cb: Callback<SandboxPublicTokenCreateResponse> | ||
| ): Promise<SandboxPublicTokenCreateResponse>; |
There was a problem hiding this comment.
we need to define two flavors of this function, one for the CPS style, and one for the promisified variant
// sandboxCreatePublicToken(String, Array<sring>,Object, Function)
sandboxPublicTokenCreate(
institutionId: string,
initialProducts: Array<string>,
options: Object,
cb: Callback<SandboxPublicTokenCreateResponse>,
): void;
// sandboxCreatePublicToken(String, Array<sring>,Object)
sandboxPublicTokenCreate(
institutionId: string,
initialProducts: Array<string>,
options?: Object,
): Promise<SandboxPublicTokenCreateResponse>;when they are both defined, typescript will pick the one that compiles.
There was a problem hiding this comment.
Thanks for the explanation and code @ntindall - should be ⚡️'d! :)
index.d.ts
Outdated
| // sandboxCreatePublicToken(String, Array<sring>,Object?, Function) | ||
| sandboxPublicTokenCreate(institutionId: string, | ||
| initialProducts: Array<string>, | ||
| options: Object, |
There was a problem hiding this comment.
nit: should we provide a typing for the options? we seem to be somewhat inconsistent about this... so maybe its "out of scope".
| institution_id: institution_id, | ||
| initial_products: initial_products, | ||
| }, | ||
| }, options, cb, true); |
There was a problem hiding this comment.
are there actuallyoptions for this route?
I'm realizing the fact that _authenticatedRequest injects options onto the request in this way is somewhat confusing...
pretty sure I devised this scheme to support the variadic arguments behavior when you use the callback style... I wonder if anyone is benefitting from that...
ignore the above. this LGTM (confirmed that there are options on the route).
|
looks good after we fix the typings @michaelckelly ! |
/sandbox/public_token/createendpoint