This repository was archived by the owner on Sep 7, 2020. It is now read-only.
Add option to pass a function for rendering error handling #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, sorry. I broke something. |
|
@pkra ping |
|
@Menci could you rebase and add a test? |
|
Test added. Commits merged into one and force-pushed. Conflits resolved. |
|
Awesome -- thanks so much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this library only print the rendering error message with
console.log. This PR add a optionconfig.errorHandlerto let developers do something on error, such as show stylized error message on the page.The current behavior is preserved via the default value of
config.errorHandler.