[Invite to a Role] | Invite to a role Email - Existing role. the existing role data for appearing on masthead option is not matching the email

[Tribunal33]

Valid Title

• I have updated the title to accurately reflect the bug description

Description

There are a few issues with the Admin > Hosted Sites > Settings Wizard > User > Edit User > Appear on Masthead options versus the Invite to a role table row options and the email that gets sent displaying previous roles. From what I can tell the masthead works as intended and this is related to invite to a role but I don't think it was part of the original design. Here is a checklist of issues I indirectly found while testing #11087

• The email that get's sent containing the appear or will not appear on masthead does not match the users & roles table when adding/editing a new role
• The email does contain the correct setting option but if the role was set to the opposite it will change once the user accepts the role without notifying them that it has changed.
• The list of existing roles only shows one previous role.
• When changing the Admin > Hosted Sites > Settings Wizard > User > Edit User > Appear on Masthead options it does not update the edited user table in Settings > Users & Roles > Edit user.
• There is a special circumstance with the Reviewer Permission level in that it is not in the Admin > Hosted Sites > Settings Wizard > User > Edit User > Appear on Masthead list.

Steps to Reproduce

1. Prerequisites: This is scenario 1 for showing the mismatch between the email and the new users & roles edit existing user (invite to a role) flow and for this you will need a user with an existing role that says it appears in the masthead but actually is not selected to appear in the masthead.

2. Login with Admin

3. Navigate to Users & Roles

4. Find an existing user and select the 3 dots menu

5. Select Edit

6. Invite the user to a new role pick a role that you know is not selected for appearing in masthead (this will be useful for the next scenario)

7. Save and Continue

8. On the email select Invite user to the role button

9. Check email with subject "You are invited to new roles"

10. Prequisites: This is scenario 2 for showing that the selected appear on masthead option changes after the invitation has been accepted. This will need to have an invitation already sent such that the appear on masthead option that is selected is not the same on the backend. If you did the 6th step prior to this then it should show the problem if you continue with this scenario.

11. Check the email with the subject "You are invited to new roles"

12. Select Accept Invitation

13. Observe that the appear on masthead option is still showing up the same as the selected option

14. Select the Accept and Continue to OJS button

15. Login with Admin or JM with access to settings

16. Navigate to Settings > users & roles

17. Find the user that accepted the new role and select the 3 dots menu

18. Select Edit

19. Observe the Appear On Masthead option

Expected Result

Scenario 1: In the Email that gets sent the Already assigned roles section should list out all the previous roles (problem 3 from checklist) and the appearing on masthead message should line up with the Settings > Users & Roles > User table

Scenario 2: In the Edit user list of current roles the appear on masthead option should be the same as the accepted invitation

Actual Result

Scenario 1: The email does not display the same appear on masthead change option as the edit user table displays

Scenario 2: The user table has been changed without any indication to the user that accepted the invitation.

Environment Details

No response

Application Version

OJS, OMP, OPS 3.5.0 and main

Logs

No response

Additional Information

No response

---

PRs:
stable-3_5_0:

• pkp/pkp-lib#11424 fix user role invitation email and UserUserGroup::withContextId() #11425
• pkp/pkp-lib#11424 submodule update ##bozana/11424-3_5_0## ojs#4903 (only submodule update)
• pkp/pkp-lib#11424 submodule update ##bozana/11424-3_5_0## omp#2007 (only submodule update)
• pkp/pkp-lib#11424 submodule update ##bozana/11424-3_5_0## ops#991 (only submodule update)

main:

• pkp/pkp-lib#11424 fix user role invitation email and UserUserGroup::withContextId() #11436

[asmecher]

Adding @bozana for a look.

[bozana]

I have changed the milestone, because I think at least some of this issues should be fixed for 3.5

[bozana]

There are several problems here, it seems:
Invitation does not contain all the existing roles: The fix is provided above, it was a bug.
User&Roles > Edit user: This forms shows the masthead value from the role (db table user_groups) instead of what user has accepted (db table user_user_groups). The fix is provided above, it was a bug.
Our dataset does not contain entries for the masthead column in the db table user_user_groups. This would need to be investigated why. Thus the testing if the issue is fixed should only be done on new invitations.
The specific reviewer case -- that the reviewer are always displayed on the masthead if they completed a review -- has not been considered in the user edit and invitations UI/pages/forms.