Skip to content

draft copyediting file copied from a discussion can not be accessed #10584

Open

Description

S. https://forum.pkp.sfu.ca/t/assoc-type-preventing-file-download-by-copyeditor-ojs-3-3-0-13/93501

See also this related meta issue: #10438.

When using the function Upload/Select File for Draft Files in Copyediting tab the users can select files from Copyediting Discussions.

  1. Also the copyeditor that is not a participant of (and thus has no access to) the discussion, that the discussion file belongs to, can select the discussion file and add it to the Draft Files area.
  2. The discussion file is copied to the Draft Files area, but it keeps the assoc_type = 520 (which means discussion file).
    It results that the copyeditor that has no access to the discussion and discussion file see the new file in the Draft Files area, but he/she cannot download the file.

I believe here are two things to consider:

  • The users that have no access to discussion files should not be able to select them from the menu Upload/Select File.
  • I would think that a file that is selected and displayed in the Draft Files area should not get the assoc_type = 520 i.e. that is should be accessed by everybody with the access to that area.

Tested on OJS 3.3. Needs to be tested for 3.4 and main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

Bug:1:LowA bug that does not have a severe consequence or affects a small number of users.

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions