Skip to content

OMP wrongly displays "Forthcoming" message if the date format is changed #10169

Closed

Description

Describe the bug
OMP will either display the catalog.forthcoming or catalog.published message on the monograph landing page, depending on the publication date of a monograph. This message is chosen based on:

https://github.com/pkp/omp/blob/stable-3_3_0/templates/frontend/objects/monograph_full.tpl#L406

but this test will fail and display Forthcoming in cases when it should not, if the Date Format in Website Settings is something other than the default. In the screenshot below, choosing the circled format results in a Forthcoming message for a monograph with a publication date in 2022. Setting it back to the default as chosen fixes the issue.

date

Seen in 3.3 but probably also in 3.4

Suggest converting these to time stamps instead, to make the math consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions