Skip to content

Conversation

touhidurabir
Copy link
Member

Copy link
Contributor

@jonasraoni jonasraoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the plugin will be fully deprecated, and considering that the issue presents a related and harder breaking change (death of scheduledTasks.xml), I think we can just unlink the submodule (there's basically no public methods to be used by 3rd-parties on this AcronPlugin class) and include a warning on the PKPApplication class:

Hook::addUnsupportedHooks('AcronPlugin::parseCronTab')

Perhaps we can confirm with Alec.


Not sure if it's done (I'll review the other PRs yet), but it's needed to update the usage of this hook across the codebase/other plugins that we're maintaining later:
https://github.com/search?q=org%3Apkp+AcronPlugin%3A%3AparseCronTab&type=code

@touhidurabir
Copy link
Member Author

Added the unsupported hook but will removed the submodule reference from .gitsubmodule once we finalise the implementation .

@asmecher asmecher merged commit 5bd8190 into pkp:main Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants