-
Notifications
You must be signed in to change notification settings - Fork 2
Stats: Fix typos in IDs #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Fix typos in IDs #20
Conversation
|
Thanks! The EDIT: noticed smogon/usage-stats#15 - if that lands then this can be merged as is |
|
Now I found several typos inherited in the aliases table. I'm thinking of adding a test case here to assert that every ID in the table actually corresponds to a Pokemon in the Dex, and then fix those here and upstream. |
classifierFixes typo in 'arentrap' and adds missing 'pursuit' element.
Backported fix from pkmn/stats#20
|
upstream aliases PR: smogon/usage-stats#16. Also fixed an instance of |
|
Original code also excludes |
|
Thanks for the great work! |
Looks like
posiongemwas inherited from https://github.com/smogon/usage-stats/blob/09e4b930d73acf2def123f4b2f0bffb5156bb763/TA.py#L222. From that same source,focussashappears twicebut removing that would require reformatting several lines.