Skip to content

Adding deno.config #234

Merged
mxcl merged 6 commits intopkgxdev:mainfrom
otherJL0:deno-config
Dec 8, 2022
Merged

Adding deno.config #234
mxcl merged 6 commits intopkgxdev:mainfrom
otherJL0:deno-config

Conversation

@otherJL0
Copy link
Contributor

@otherJL0 otherJL0 commented Dec 6, 2022

Adding a deno.config file provides:

  • A recognizable file for the deno lsp to reference when working in editors other than VSCode
  • A set of tasks to build and test with all flags with deno task build and deno task test

At this time the "fmt" section of the config is set to ignore all files since the current style deviates from deno's default style.

@what-the-diff
Copy link

what-the-diff bot commented Dec 6, 2022

  • .gitignore
  • vscode settings
  • README markdownlint configs and deno tasks added to the readme file
  • new jsonc configuration for deno compiler options, import map, fmt and task scripts (deno run)
  • removed tsconfig since it is not needed anymore with a jsonc configuration in place

@mxcl
Copy link
Contributor

mxcl commented Dec 6, 2022

Do we still need tsconfig.json?

@mxcl
Copy link
Contributor

mxcl commented Dec 6, 2022

We should probably change the tea scripts in our README to use deno build and deno test. Edit or however you call these “tasks”, since I haven't read the docs.

@otherJL0
Copy link
Contributor Author

otherJL0 commented Dec 6, 2022

We don't really need tsconfig.json anymore, I can remove it and update the PR. And yeah we could update the README with the new task commands.

@lino-levan
Copy link
Contributor

Any particular reason why this is a .json and not a .jsonc? I don't think it matters yet but if we ever want to add comments to it I think it would be valuable to have.

@jhheider
Copy link
Contributor

jhheider commented Dec 6, 2022

At this time the "fmt" section of the config is set to ignore all files since the current style deviates from deno's default style.

A better question is: "should we codify our deviations and enable formatting?"

@mxcl
Copy link
Contributor

mxcl commented Dec 6, 2022

A better question is: "should we codify our deviations and enable formatting?"

probs, though necessary for this PR!

@otherJL0
Copy link
Contributor Author

otherJL0 commented Dec 7, 2022

deno-config.json is now deno-config.jsonc to allow for future comments. The README has been updated to use the more succinct deno task syntax for local development

@mxcl mxcl merged commit 2072511 into pkgxdev:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants