v2

[mxcl]

No description provided.

[mxcl]

@jhheider what's going on with these failrues you think?

[jhheider]

good question. introduced on the last commit to pkgxdev/pkgx.rs. which looked like a simple re-org.

[mxcl]

yeah I guess it’s my fault, happens there too

[jhheider]

nope, looks like it's the build of cargo-taupaulin.

[jhheider]

same version (0.31.4) but maybe an unfrozen dep updated. winnow probably.

[jhheider]

6 minutes ago: https://crates.io/crates/winnow

[jhheider]

a lot of people aren't gonna like that.

[jhheider]

winnow-rs/winnow#690

[jhheider]

looks like the re-run is gonna work.

[jhheider]

https://x.com/GithubProjects/status/1877626526293713314

[coveralls]

Pull Request Test Coverage Report for Build 12768583963

Details

• 13 of 791 (1.64%) changed or added relevant lines in 17 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-90.3%) to 1.643%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
crates/lib/src/install_multi.rs	0	12	0.0%
crates/lib/src/utils.rs	0	12	0.0%
crates/cli/src/help.rs	0	14	0.0%
crates/cli/src/execve.rs	0	15	0.0%
crates/lib/src/config.rs	0	18	0.0%
crates/lib/src/resolve.rs	0	26	0.0%
crates/lib/src/inventory.rs	0	28	0.0%
crates/lib/src/sync.rs	0	28	0.0%
crates/lib/src/cellar.rs	0	31	0.0%
crates/lib/src/types.rs	0	34	0.0%

Totals
Change from base Build 12663326816:	-90.3%
Covered Lines:	13
Relevant Lines:	791

---

💛 - Coveralls

[jhheider]

pkgxdev/pantry@5ef492d

[mxcl]

lol

[jhheider]

if you need static ffi, consider: pkgxdev/pantry@b6e6bd6

[mxcl]

#5 0.120 pkgx: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by pkgx)

Could be more problematic to support. Not sure how far back we can expect glibc support with rust to go. Not sure how to fix that either. Calling it a day for today.

[jhheider]

if you're feeling perverse, i think you can static link musl. but, yes, glibc is the worst thing about linux support.

[mxcl]

Easy solution was to build in debian:buster-slim. Which then makes me want to check our self hosted linux runners are debian:buster-slim right?

[mxcl]

Some(Ssl(ErrorStack([Error { code: 167772294, library: "SSL routines", function: "tls_post_process_server_certificate", reason: "certificate verify failed", file: "ssl/statem/statem_clnt.c", line: 2093 }]))) }, X509VerifyResult { code: 20, error: "unable to get local issuer certificate" })) }

ah. Well obv. vendoring OpenSSL is not enough. Should be enough to include the root certificate for https://dist.pkgx.sh presumably. No clue how to do that but will figure it out.

[jhheider]

include_bytes!() probably

[jhheider]

our self hosted linux runners are debian:buster-slim right?

Right.

[jhheider]

self hosted linux runners are debian:buster-slim right?

• https://github.com/pkgxdev/pantry/blob/3001c1244ffde0b1521b49e1b500c8259d522f11/.github/scripts/get-ci-matrix.ts#L69-L73
• https://github.com/pkgxdev/ops/blob/5d9ef917c0ee330768884c56ac1dde3cce6af026/gha-runner/Dockerfile#L1-L2

[jhheider]

LFGoooooooo!

[mxcl]

how come? Trying to keep it minimal. Did I miss somewhere we need this?

[jhheider]

That was the last failure with v0.1.0. likely fixed in v0.2.0.

[mxcl]

ah ok, will remove for my own piece of mind

[mxcl]

Note I want ca-certs gone too (and the rest lol), but that fix was more work for now and wanted some progress.

[jhheider]

i've been noodling this. embedding certificate info usually isn't a best practice, since it changes with some regularity. but it should be possible. googling suggests:

• create a Certificate object in build.rs
• serialize it
• provide it as a build env
• deserialize and consume it using env!()
• use ClientBuilder to create the reqwest client.

[jhheider]

looks good. some style questions.