Shell integration breaks prompt plugins

[sporkd]

The shell integration for tea -package and dev are breaking my prompt. I am using a prompt library called Starship in ZSH to display a custom prompt. In some cases is seems the tea prompt gets appended on the line before my PS1. In other cases it's blowing away PS1 all together (see screen grabs below where PS1 becomes blank).

My thought is that maybe tea shouldn't be messing with the prompt because it would be hard to predict all the different ways installed plugins might be using it. Starship also already has functionality to show current version of node, etc. in your prompt.

However, I imagine the proper (and neat 🤩) way to implement this would be creating a Starship module for tea, or other prompt plugins out there. Then users could enable the tea module in favor of using the existing modules for node, etc.

Tea version: 1.0.0-alpha.4

After running tea -node my PS1 gets overwritten and and now promptless:

After running dev and then cd .. my PS1 gets overwritten and and now promptless again:

[mxcl]

the code is just export PS1="(tea) $PS1", which probs is naive. Any clue what we should be doing instead?

[mxcl]

Conda supports CONDA_CHANGEPS1=false and probs we need to do something similar.

[sporkd]

Actually @mxcl I didn't think to test it without starship enabled. It seems to be a more general problem with prompt getting blown away on package remove.

My thought is there's probably something on package remove that's overwriting the prompt instead of reverting (i.e. It would probably need to remember what PS1 was before modifying it). Prepending on package add seems less problematic, but maybe not desired in case of prompt library like starship, spaceship, powerlevel, etc.

[mxcl]

Oddly I cannot reproduce

~ echo $PS1
%F{086}%~%{%} 
~ tea +node
(tea) ~ tea -node
~ echo $PS1
%F{086}%~%{%} 
~ 

[mxcl]

k I can see how it happens since if we cannot for some reason get the existing PS1 we unset it instead when restoring it.

I may just disable the prompt mangling for beta.1 since it has other issues.

Would be good to understand better this stuff, it's new to me.

[jedahan]

If you do restore prompt manipulation, please make it opt-in.

[mxcl]

We will not likely make it opt in since generally this is what users expect and want, but it will be opt out. I get how you feel as I don't like it either, but it is not up to me how humanity—in general—behaves.

[jedahan]

Then please make it only manipulate prompts that are known to pkgx instead of generically adding to PS1.

[mxcl]

Happy to do the right thing. If you can help me understand how to do that then it will definitely be the case. Look forward to your assistance.