pkgm shim preserves constraints it was called
#61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pkgm shim functionality to preserve package constraints as passed in through the arguments, ensuring that a package’s constraint is maintained when shimming.
- Refactors the loop to process arguments instead of iterating on json.pkgs.
- Stores and applies semantic version constraints when building the shim command.
| if (pkgs.length > 1) throw new Error(`ambiguous pkg: ${arg}`); | ||
| args_pkgs[pkgs[0].project] = utils.pkg.parse(arg).constraint; | ||
| projects_we_care_about.push(pkgs[0].project); | ||
| const companions = await hooks.usePantry().project(pkgs[0]).companions(); |
There was a problem hiding this comment.
The project() call is passed pkgs[0] instead of pkgs[0].project; this may cause runtime errors if the function expects a project identifier string.
Suggested change
| const companions = await hooks.usePantry().project(pkgs[0]).companions(); | |
| const companions = await hooks.usePantry().project(pkgs[0].project).companions(); |
jhheider
approved these changes
Mar 29, 2025
mxcl
force-pushed
the
shim-preserves-constraints
branch
3 times, most recently
from
4083102 to
2d616c4
Compare
thus `shim mash` shims to `mash*` but `shim mash^0.3` shims to ^0.3
mxcl
force-pushed
the
shim-preserves-constraints
branch
from
2d616c4 to
91cf106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thus
shim mashshims tomash*butshim mash^0.3shims to ^0.3