Skip to content

Conversation

@mxcl
Copy link
Member

@mxcl mxcl commented Mar 14, 2025

No description provided.

@mxcl
Copy link
Member Author

mxcl commented Mar 14, 2025

This does not delete the previous pkgs/project/v1.2.3 entry.

This may actually be our preference for cases where there is overlap, but this seems like a bug right now since it also causes pkgm ls to list both entries.

@jhheider
Copy link
Contributor

it's interesting with hard links. i think you'd basically need all the inodes from the target directory set, then all the inodes from $base/pkgs for comparison. that sounds really awful.

Copy link
Contributor

@jhheider jhheider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the answer for unlinked packages is the not-yet-considered prune action. which would involve a long tree walk for inodes.


- run: ./pkgm.ts i hyperfine@1.18
- run: ./pkgm.ts outdated | grep hyperfine
- run: ./pkgm.ts update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we subsequently test that hyperfine --version is >1.18 for completeness? or does that make us too dependent on its version output?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can add this using semverator for sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh I cannot be arsed to parse the output into versions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#46

@mxcl mxcl merged commit 8ef5cf9 into main Mar 14, 2025
3 checks passed
@mxcl mxcl deleted the update branch March 14, 2025 20:14
jhheider added a commit that referenced this pull request Mar 14, 2025
jhheider added a commit that referenced this pull request Mar 14, 2025
jhheider added a commit that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants