Skip to content

fix pkging to pkgx #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxcl merged 1 commit into from
Mar 12, 2025
Merged

fix pkging to pkgx #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions pkgm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ async function install(args: string[], basePath: string) {

const self = fromFileUrl(import.meta.url);
const pkgx_dir = Deno.env.get("PKGX_DIR") || `${Deno.env.get("HOME")}/.pkgx`;
const needs_sudo = Deno.uid() != 0 && basePath === "/usr/local";
const needs_sudo = basePath === "/usr/local" && !writable("/usr/local");

const runtime_env = expand_runtime_env(json, basePath);

Expand Down Expand Up @@ -493,7 +493,8 @@ async function uninstall(arg: string) {
Deno.exit(1);
}

const needs_sudo = files.some((p) => p.string.startsWith("/usr/local"));
const needs_sudo = files.some((p) => p.string.startsWith("/usr/local")) &&
!writable("/usr/local");
if (needs_sudo) {
{
const { success, code } = await new Deno.Command("/usr/bin/sudo", {
Expand Down Expand Up @@ -546,3 +547,14 @@ async function uninstall(arg: string) {
}
}
}

function writable(path: string) {
try {
//FIXME this is pretty gross
Deno.mkdirSync(join(path, ".writable_test"), { recursive: true });
Deno.remove(join(path, ".writable_test"));
return true;
} catch {
return false;
}
}
Loading