File Exists Error when in odd state

[drewbitt]

Issue

❯ pkgm install mpv
error: Uncaught (in promise) AlreadyExists: File exists (os error 17): symlink '/opt/freedesktop.org/fontconfig/v2.14.1/share/fontconfig/conf.avail/65-nonlatin.conf' -> '/Users/drewbitt/.local/pkgs/freedesktop.org/fontconfig/v2.14.1/etc/fonts/conf.d/65-nonlatin.conf'
  Deno.symlinkSync(src, dst);
       ^
    at Object.symlinkSync (ext:deno_fs/30_fs.js:504:3)
    at symlink_with_overwrite (file:///opt/homebrew/bin/pkgm:500:8)
    at processEntry (file:///opt/homebrew/bin/pkgm:375:7)
    at eventLoopTick (ext:core/01_core.js:178:7)
    at async processEntry (file:///opt/homebrew/bin/pkgm:363:9)
    at async processEntry (file:///opt/homebrew/bin/pkgm:363:9)
    at async processEntry (file:///opt/homebrew/bin/pkgm:363:9)
    at async processEntry (file:///opt/homebrew/bin/pkgm:363:9)
    at async mirror_directory (file:///opt/homebrew/bin/pkgm:350:3)
    at async install (file:///opt/homebrew/bin/pkgm:153:5)

~ took 4s

Scenario

• I had pkgm installed version of mpv in ~/.local/bin, but it was when pkgm was older, it did not detect it with list. I wanted a newer version. I ran rm ~/.local/bin/mpv
• Installed it back pkgm install mpv. Looked and instead of installing just mpv, it put like 50 new binaries in ~/.local/bin of its dependencies.
• Unacceptable. Just removing mpv did not remove all the extras, so I did a rm -rf ~/.local/bin
• Can no longer install mpv, even after wiping much of my ~/.local and starting over.

After rm -rf ~/.local/pkgs/freedesktop.org/fontconfig and rm -rf /Users/drewbitt/.local/etc/fonts/conf.d/` I can finally get

error: Uncaught (in promise) Error: Directory not empty (os error 66): remove '/Users/drewbitt/.local/pkgs/pcre.org/v2'
    Deno.removeSync(dst);
         ^
    at Object.removeSync (ext:deno_fs/30_fs.js:247:3)
    at symlink_with_overwrite (file:///opt/homebrew/bin/pkgm:498:10)
    at create_v_symlinks (file:///opt/homebrew/bin/pkgm:452:5)
    at eventLoopTick (ext:core/01_core.js:178:7)
    at async install (file:///opt/homebrew/bin/pkgm:162:5)
    at async file:///opt/homebrew/bin/pkgm:65:20

Final fix

rm -rf ~/.local/pkgs/freedesktop.org/fontconfig
rm -rf /Users/drewbitt/.local/etc/fonts/conf.d/
rm -rf ~/.local/pkgs/pcre.org

Please recover from this state, which may be odd, but until #43 may come up. I don't want these extras in my ~./local/bin at all, though.

Side note

❯ pkgm install mpv
/Users/drewbitt/.local/bin/bzip2recover
/Users/drewbitt/.local/bin/bzmore
/Users/drewbitt/.local/bin/bzgrep
/Users/drewbitt/.local/bin/bzdiff
/Users/drewbitt/.local/bin/bunzip2

Still a bunch of stuff I don't want

[drewbitt]

❯ mpv
dyld[3882]: Library not loaded: @rpath/harfbuzz.org/v9/lib/libharfbuzz.dylib
  Referenced from: <791A9A2C-7E86-3325-A2A5-229637969E5C> /Users/drewbitt/.local/pkgs/github.com/libass/libass/v0.17.3/lib/libass.9.dylib
  Reason: tried: '/Users/drewbitt/.local/pkgs/github.com/libass/libass/v0.17.3/lib/../../../../../harfbuzz.org/v9/lib/libharfbuzz.dylib' (no such file), '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx/harfbuzz.org/v9/lib/libharfbuzz.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx/harfbuzz.org/v9/lib/libharfbuzz.dylib' (no such file), '/usr/lib/swift/harfbuzz.org/v9/lib/libharfbuzz.dylib' (no such file, not in dyld cache), '/System/Volumes/Preboot/Cryptexes/OS/usr/lib/swift/harfbuzz.org/v9/lib/libharfbuzz.dylib' (no such file), '/Users/drewbitt/.local/pkgs/mpv.io/v0.39.0/bin/../../../harfbuzz.org/v9/lib/libharfbuzz.dylib' (no such file), '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx/harfbuzz.org/v9/lib/libharfbuzz.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx/harfbuzz.org/v9/lib/libharfbuzz.dylib' (no such file), '/usr/lib/swift/harfbuzz.org/v9/lib/libharfbuzz.dylib' (no such file, not in dyld cache), '/System/Volumes/Preboot/Cryptexes/OS/usr/lib/swift/harfbuzz.org/v9/lib/libharfbuzz.dylib' (no such file), '/Users/drewbitt/.local/pkgs/mpv.io/v0.39.0/bin/../../../harfbuzz.org/v9/lib/libharfbuzz.dylib' (no such file)
zsh: abort      mpv

~
❯ pkgm uninstall mpv
uninstalling ~/.local/pkgs/mpv.io

~
❯ pkgm install mpv
error: Uncaught (in promise) Error: Directory not empty (os error 66): remove '/Users/drewbitt/.local/pkgs/pcre.org/v2'
    Deno.removeSync(dst);
         ^
    at Object.removeSync (ext:deno_fs/30_fs.js:247:3)
    at symlink_with_overwrite (file:///opt/homebrew/bin/pkgm:498:10)
    at create_v_symlinks (file:///opt/homebrew/bin/pkgm:452:5)
    at eventLoopTick (ext:core/01_core.js:178:7)
    at async install (file:///opt/homebrew/bin/pkgm:162:5)
    at async file:///opt/homebrew/bin/pkgm:65:20

Bad install but its back again after uninstalling, which is a less odd scenario :)

[mxcl]

This could be an issue with our unwise naming of pcre.org/v2. Let me take a look.

[mxcl]

Unacceptable. Just removing mpv did not remove all the extras

Auto-remove is an open ticket (#43). But this is the nature of installing things with a package manager. Even brew only gained auto-remove 2 years ago. Off hand I can't think of any package manager that auto-removes for the uninstall command.

If you don’t want all these “extras” installed we provide pkgm shim mpv.

[drewbitt]

It is just notable that my previous use of this tool with pkgm install package only installed the package to ~/.local/bin, and now it installs 50 things. I don't even mind them existing on disk, but I don't want them in with my actual desired binaries, as they are in my PATH.

[jhheider]

It is just notable that my previous use of this tool with pkgm install package only installed the package to ~/.local/bin, and now it installs 50 things. I don't even mind them existing on disk, but I don't want them in with my actual desired binaries, as they are in my PATH.

the old behavior was brought back with pkgm shim $foo (aka, pkgm stub $foo) by popular request.

pkgm/pkgm.ts

Lines 217 to 269 in 4972d61

	async function shim(args: string[], basePath: string) {
	const pkgx = get_pkgx();
	await ensureDir(join(basePath, "bin"));
	const json = (await query_pkgx(pkgx, args))[0];
	const args_pkgs: Record<string, semver.Range> = {};
	const projects_we_care_about: string[] = [];
	for (const arg of args) {
	const pkgs = await hooks.usePantry().find(arg);
	if (pkgs.length == 0) throw new Error(`no such pkg: ${arg}`);
	if (pkgs.length > 1) throw new Error(`ambiguous pkg: ${arg}`);
	args_pkgs[pkgs[0].project] = utils.pkg.parse(arg).constraint;
	projects_we_care_about.push(pkgs[0].project);
	const companions = await hooks.usePantry().project(pkgs[0]).companions();
	projects_we_care_about.push(...companions.map((x) => x.project));
	}
	for (const pkg of json.pkgs) {
	if (!projects_we_care_about.includes(pkg.pkg.project)) continue;
	for (const bin of ["bin", "sbin"]) {
	const bin_prefix = pkg.path.join(bin);
	if (!bin_prefix.exists()) continue;
	for await (const entry of Deno.readDir(bin_prefix.string)) {
	if (!entry.isFile && !entry.isSymlink) continue;
	const name = entry.name;
	const quick_shim = Deno.build.os == "darwin" &&
	pkgx == "/usr/local/bin/pkgx";
	const interpreter = quick_shim
	? "/usr/local/bin/pkgx"
	: "/usr/bin/env -S pkgx";
	const range = args_pkgs[pkg.pkg.project];
	const arg = `${pkg.pkg.project}${`${range}` == "*" ? "" : `${range}`}`;
	const shim = `#!${interpreter} --shebang --quiet +${arg} -- ${name}`;
	if (existsSync(join(basePath, "bin", name))) {
	await Deno.remove(join(basePath, "bin", name));
	}
	// without the newline zsh on macOS fails to invoke the interpreter with a bad interpreter error
	await Deno.writeTextFile(join(basePath, "bin", name), shim + "\n", {
	mode: 0o755,
	});
	console.error(join(basePath, "bin", name));
	}
	}
	}
	}

[mxcl]

Yeah, use pkgm shim instead. That is the same as the v1 pkgx install command. pkgm by default is a normal package manager, so installing things will install all the deps too.