+minikube +go-bindata #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
go-bindata is a small utility which generates Go code from any file.
Member
|
We're not familiar with better ways as yet! Though potentially setting some env would do it |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds minikube and it's dependency go-bindata to the pantry.
I had some issues getting
go-bindatato compile in tea as it's latest release is not using go modules - which caused me further issues with$GOROOT,$GOPATHand name clashes 😅. I ended up patching in ago.modfile comparably to how it's done in the nixpkgs collection. Since the package doesn't have any external dependencies this ended up being simpler, lmk if there's a better way to work around this.Resolves #331