Skip to content

Package google.com/firebase-tools#3604

Merged
jhheider merged 3 commits intopkgxdev:mainfrom
svenjacobs:google.com/firebase-tools
Oct 10, 2023
Merged

Package google.com/firebase-tools#3604
jhheider merged 3 commits intopkgxdev:mainfrom
svenjacobs:google.com/firebase-tools

Conversation

@svenjacobs
Copy link
Contributor

A follow up to #3600, now the right way.
Hope everything is right because this is my first package.

@svenjacobs
Copy link
Contributor Author

Hm, something is not right. The tests worked on my machine.

@mxcl
Copy link
Contributor

mxcl commented Oct 10, 2023

yeah agreed, this looks like it should work

@jhheider
Copy link
Contributor

Look at the bottle extraction: https://github.com/pkgxdev/pantry/actions/runs/6471355430/job/17569763324?pr=3604

it's missing most of the files it's likely to need, i believe. it may require --install-links, which as i recall is badly named, and keeps changing from default to non-default behavior. we have a variety of npm packages in the pantry, and no real agreement between them which flags are used :(

@svenjacobs
Copy link
Contributor Author

Thanks @jhheider, that did the trick!

@jhheider
Copy link
Contributor

thanks for the contribution, @svenjacobs !

@jhheider jhheider merged commit 62da7fa into pkgxdev:main Oct 10, 2023
@svenjacobs svenjacobs deleted the google.com/firebase-tools branch October 10, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants