Package google.com/firebase-tools#3604
Merged
jhheider merged 3 commits intopkgxdev:mainfrom Oct 10, 2023
svenjacobs:google.com/firebase-tools
Merged
Package google.com/firebase-tools#3604jhheider merged 3 commits intopkgxdev:mainfrom svenjacobs:google.com/firebase-tools
jhheider merged 3 commits intopkgxdev:mainfrom
svenjacobs:google.com/firebase-tools
Conversation
Contributor
Author
|
Hm, something is not right. The tests worked on my machine. |
Contributor
|
yeah agreed, this looks like it should work |
Contributor
|
Look at the bottle extraction: https://github.com/pkgxdev/pantry/actions/runs/6471355430/job/17569763324?pr=3604 it's missing most of the files it's likely to need, i believe. it may require |
Contributor
Author
|
Thanks @jhheider, that did the trick! |
Contributor
|
thanks for the contribution, @svenjacobs ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up to #3600, now the right way.
Hope everything is right because this is my first package.