Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinniped.dev #3564

Merged
merged 4 commits into from
Oct 7, 2023
Merged

pinniped.dev #3564

merged 4 commits into from
Oct 7, 2023

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Oct 7, 2023

@aslafy-z aslafy-z force-pushed the new/pinniped.dev branch 4 times, most recently from f2fd58a to d6a8859 Compare October 7, 2023 17:23
Signed-off-by: GitHub <noreply@github.com>
@aslafy-z aslafy-z marked this pull request as ready for review October 7, 2023 17:38
@aslafy-z aslafy-z marked this pull request as draft October 7, 2023 17:44
@aslafy-z
Copy link
Contributor Author

aslafy-z commented Oct 7, 2023

aarch64 is not officially supported, that's why I did not added it in the first time... What is the pkgx plan for that?
Can you please add comments to the PR instead or editing it? I had pending changes and it's a bit confusing. 🙏

edit: looks like the changes were done: vmware-tanzu/pinniped#1386 (comment). Pinniped will start supporting these!

@aslafy-z aslafy-z marked this pull request as ready for review October 7, 2023 18:07
@jhheider
Copy link
Contributor

jhheider commented Oct 7, 2023

Can you please add comments to the PR instead or editing it?

Sure. Apologies. In general, if it builds and runs, we package it.

@jhheider jhheider merged commit 8c42467 into pkgxdev:main Oct 7, 2023
19 checks passed
@aslafy-z aslafy-z deleted the new/pinniped.dev branch October 7, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants