Skip to content

Conversation

@and-ri
Copy link
Contributor

@and-ri and-ri commented Jun 30, 2023

closes #359

@what-the-diff
Copy link

what-the-diff bot commented Jun 30, 2023

PR Summary

  • Introduction of new file package.yml
    A new file titled package.yml has been created in the projects/github.com/sindresorhus/macos-term-size directory.

  • Added distributable Section
    The package.yml file now includes a distributable section. This section contains details such as a URL for downloading the application and settings to manage application components.

  • Inclusion of versions Section
    A new section called versions has been added that maintains reference to the GitHub repository, helping keep track of different versions of the software from this repository.

  • Supported Platforms Recoded in platforms Section
    In the platforms section, we have listed out all the platforms that our software supports. This ensures maximum usability across various platforms.

  • Details of Building Process in build Section
    The build section helps automate the building process by specifying prerequisites and a script for building. This optimizes the efficiency during the development process.

  • Enumeration of Provide Files in provides Section
    The provides section lists the files that this particular package provides. It helps in understanding exactly what is included in this package.

  • Addition of a Test Command
    A test command has been added to ensure that all components are functioning as intended during the development phase.

  • No Newline at End of File
    Please note that, the package.yml file does not contain a newline at the end of the file. This could lead to some tools not recognizing the end of the file correctly.

@and-ri
Copy link
Contributor Author

and-ri commented Jul 12, 2023

Test:
Opening '/dev/tty' failed (6): Device not configured

@jhheider Could it be because we are running it on a virtual machine? It works fine on my Mac.

@mxcl
Copy link
Member

mxcl commented Jul 12, 2023

@sindresorhus :)

@mxcl
Copy link
Member

mxcl commented Jul 12, 2023

I note that the release notes say:

The binary is now codesigned by the Node.js Foundation and hardened (sindresorhus/terminal-size#16)

I wonder if we can verify this codesigning easily enough. All vendored bins should be checked.

@and-ri and-ri marked this pull request as ready for review July 12, 2023 15:06
@jhheider
Copy link
Contributor

jhheider commented Jul 12, 2023

Could it be because we are running it on a virtual machine? It works fine on my Mac.

Almost certainly.

I wonder if we can verify this codesigning easily enough. All vendored bins should be checked.

$ codesign -dvv ~/.tea/tea.xyz/v0/bin/tea
Executable=/Users/jacob/.tea/tea.xyz/v0.38.1/bin/tea
Identifier=deno
Format=Mach-O thin (arm64)
CodeDirectory v=20400 size=662760 flags=0x0(none) hashes=20706+2 location=embedded
Signature size=8966
Authority=Developer ID Application: Tea Inc. (7WV56FL599)
Authority=Developer ID Certification Authority
Authority=Apple Root CA
Timestamp=Jul 4, 2023 at 23:36:39
Info.plist=not bound
TeamIdentifier=7WV56FL599
Sealed Resources=none
Internal requirements count=1 size=164

checking the ^Authority= lines and ^TeamIdentifier= line... should be sufficient?

@jhheider jhheider merged commit eca2a14 into pkgxdev:main Jul 13, 2023
@and-ri and-ri deleted the new/github.com/sindresorhus/macos-term-size branch September 20, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

+macos-term-size (305/548)

3 participants