Skip to content
This repository was archived by the owner on Mar 15, 2023. It is now read-only.

fix(python~3.7) #561

Merged
jhheider merged 1 commit into from
Mar 14, 2023
Merged

fix(python~3.7) #561

jhheider merged 1 commit into from
Mar 14, 2023

Conversation

@jhheider
Copy link
Contributor

@jhheider jhheider commented Mar 13, 2023 •
edited
Loading

python3.7-config is a symlink

resolves pkgxdev/pantry#656
resolves #560
resolves #559
resolves #558
resolves #557

proof of success: https://github.com/teaxyz/pantry.core/actions/runs/4410951088

@what-the-diff
Copy link

what-the-diff bot commented Mar 13, 2023

  • The shebang line in the python-config.py file was changed to use /usr/bin/env
  • A check for symlinks is added before changing the shebang line, so that it doesn't change a symlinked binary's path

@jhheider jhheider force-pushed the fix(python3.7) branch 2 times, most recently from da10513 to 6769d1d Compare March 14, 2023 00:19
jhheider
jhheider commented Mar 14, 2023
View reviewed changes
projects/python.org/package.yml
Comment on lines 70 to 74
for binfile in $shebangs $confdir/python-config.py; do
binfile=$(readlink -f $binfile)
sed -i.bak -e 's|#!{{ prefix }}/bin/|#!/usr/bin/env |g' $binfile
rm $binfile.bak
done
Copy link
Contributor Author

@jhheider jhheider Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need to use this trick more often.

@jhheider jhheider merged commit c5595d2 into main Mar 14, 2023
@jhheider jhheider deleted the fix(python3.7) branch March 14, 2023 00:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@jhheider