Closed
Conversation
Eomm
reviewed
Jan 14, 2022
Eomm
approved these changes
Jan 14, 2022
Collaborator
|
what if we make an effort to bring the discussion in #38 to a conclusion, and then update the examples in the README as needed? |
Collaborator
Author
|
This was intended to be fairly safe catch up with multiple small fixes. Failed. Closing PR to avoid discussion here which I don't feel will be best place or very focused. Will submit some of the hopefully no-brainer changes individually so easy to yes/no quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the README FAQ with changes from #21 and #22, short option group plans from #2, and some updates to speculative or slightly incorrect comments.
I also updated the
--QA to match the current behaviour. (With which I agree.)