Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updates to comments and code per feedback #101

Merged
merged 4 commits into from
Apr 11, 2022

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Apr 11, 2022

Did a second pass through applying suggestions so far from node PR

  • improving comments
  • more arrow functions

@shadowspawn shadowspawn changed the title refactor: fix types and the like based on PR feedback docs: fix typos in comments and the like based on PR feedback Apr 11, 2022
@shadowspawn shadowspawn changed the title docs: fix typos in comments and the like based on PR feedback docs: fix typos in comments based on PR feedback Apr 11, 2022
@shadowspawn shadowspawn changed the title docs: fix typos in comments based on PR feedback refactor: minor updates to comments and code per feedback Apr 11, 2022
@shadowspawn shadowspawn changed the title refactor: minor updates to comments and code per feedback refactor: updates to comments and code per feedback Apr 11, 2022
@shadowspawn shadowspawn marked this pull request as ready for review April 11, 2022 09:50
@bcoe bcoe merged commit 95536a0 into pkgjs:main Apr 11, 2022
@shadowspawn shadowspawn deleted the feature/pr-nits branch June 5, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants