Export RemoveFile method #548
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Guilherme Tramontina <guilherme.tramontina@indebted.co>
Collaborator
|
I’m kind of averse to this. We probably shouldn’t have exposed In the linked issue, I covered what the correct solution should be, I just haven’t had time to implement it. |
This was referenced Aug 24, 2023
Collaborator
|
Essentially obsoleted by #618 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to address partially similar to issue #468 in our case.
In the same way we have the
RemoveDirectorymethod as an exported method, we put the decision in the hands of the developer of which one to choose.What do you think?