This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
[KH-13246] More Errors #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns and scoped it to KOHO packages only
* Made Base constructor public * added InvalidArgumentError
|
Oops, wrong fork sorry! |
|
I was wondering why a JIRA ticket was attached. 😆 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more errors to have better granularity. The structure and thought behind these additions is as follows:
Data State Errors
AlreadyExists [NEW]
The resource trying to be created already exists.
ConflictingChanges [NEW]
Changes to a resource cannot be performed due to conflicts with other existing resources.
NotFound
Resource is not found.
Parameter Errors
BadFormat [NEW]
Data provided is of the correct type but is in a format that could not be understood.
InvalidArgument
Data provided was invalid.
MissingAgrument [NEW]
Data was expected but is missing.
UnsupportedType
Data has been provded in an unsupported type.
Uninitialzied [NEW]
A dependency hasn’t been initialized but is required.
General System Errors
IO [NEW]
An I/O operation failed.
DataLoad
Data could not be loaded.
Network [NEW]
Network operation failed.
Permission Errors
AccessDenied [NEW]
Current context does not have permission to access this action.
Disabled [NEW]
The action is disabled (feature flagging, etc) in a way that’s not necessarily specific to this context.
Limited [NEW]
The action has been temporarily limited (rate limiting, etc) in a way that is not based off of the application state.