Enhancements to CLI interface #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The built in commands are member functions of the CLI class so we can't easily mix them with free functions a user might register. Thus there are two lists now. It might make sense to add a void *context to the callbacks of user commands. To be discussed.
This is basically just copy&paste from the REST API.
pkerspe
approved these changes
Dec 4, 2023
|
Hi @houz looks fine to me code-wise, could you please also update the readme in the section "Library API documentation" for the new exposed API functions to register user commands? And optional, but nice to have: provide a example ino file in examples folder that shows usage of user provided CLI function other than that, thanks a lot for you contribution |
|
Done, I pushed the changes to my fork. |
pkerspe
approved these changes
Dec 5, 2023
|
Thank you very much for the quick and pleasant experience. :-) |
|
@houz thanks for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I added the ability to register user defined functions in the CLI API. Unfortunately I had to introduce a second list of commands in the
ESPStepperMotorServer_CLIclass, because the internal callbacks are member functions of the class, while external callbacks need to be free functions.While at it, I also ported the ability to set speed, acceleration and deceleration from the REST API to CLI.
Closes #42.