V3.2.4 beta/build fixes #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding travis label
Inadvertently changed in: 4de4bc5 ("New packaging with systemd", 2017-12-20)
Set client_state CLIENT_ERR if connection was closed from client side
as respnse like "... OK [MODIFIED 7,9] ..." not "...OK [MODIFIED [7,9]]..."
Reinstate systemd notify service type
fix detection of systemd libs on systemd >= 230
Fix fd leaks in clientbase
update to date
According to RFC7162 section 3.1.3.0 MODIFIED keyword should be used
…is "* OK Still here".
When the content-type header is not present in an email, dbmail generates a possibly incomplete BODYSTRUCTURE:
BODYSTRUCTURE ("text" "plain" NIL NIL "7BIT" 4669 2294 NIL NIL NIL NIL)
Rather than:
BODYSTRUCTURE ("text" "plain" NIL NIL NIL "7BIT" 4669 2294 NIL NIL NIL NIL)
Non java clients seem to be fine with this, but java clients barf, sometimes quietly.
Looking through the code, I believe this difference is unintended.
It seems to be due to a call in dm_misc.c to:
imap_append_hash_as_string(GList *list, const char *type)
Where type is null, which happens when a call to:
g_mime_object_get_header(object, "Content-Type")
returns a null for the Content-Type, ie, when there is no Content-Type header.
The code in imap_append_hash_as_string returns an unmodified list when the passed-in type is null, where I believe it should append a 'NIL' and return the list.
I will submit a merge request with this implemented shortly, and the change does fix the issue in my environment.
*nbeta-git
added trace (according to review)
…lid_bodystructure merge from awheeler:fix_imap_invalid_bodystructure
Simplify and fix AC_CHECK_HEADERS for libzdb works with libzdb +3.2.2
update from master in order to recompile config.
Libzdb 3.2.2 configuration update
Create ccpp.yml
Nbeta git patch 1
SImple Compilation Workflow
update from original
…en dburi was used to configure database connection.
…_addition dburi application-name addition
Update from origin
Reconfigured all configuration files
Version 3.2.4 beta
update from base
…her compatibilities raised by other engines, pjstevns#18
Fix, remove alias error pjstevns#18
libzdb has been skipping with a .pc file for years, and using it simplifies locating the headers and library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
here are 3 trivial build fixes / improvements.
Matthieu