Add support of out-of-dialog SIP transactions #4155
+192
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support of out-of-dialog transactions to PJSUA and PJSUA2. The requests are sent in the context of an account. The API is similar to that of an in-dialog transaction.
sauwming
reviewed
Nov 14, 2024
nanangizz
reviewed
Nov 14, 2024
pjsip/include/pjsua-lib/pjsua.h
Outdated
| PJ_DECL(pj_status_t) pjsua_acc_send_request(pjsua_acc_id acc_id, | ||
| const pj_str_t *dest_uri, | ||
| const pj_str_t *method_str, | ||
| const pjsua_msg_data *msg_data); |
There was a problem hiding this comment.
Add few params which perhaps can be useful in the future:
- app user-data/token (void *),
- generic options/settings (void *): for now perhaps must be NULL, for extensibility in the future, so we don't need to create
pjsua_acc_send_request2():)
There was a problem hiding this comment.
Looks like only token/user-data was added and it is specified as "unused" while it should be usable (as opposed to must-be-NULL :)
Actually user-data/token and settings are actually different:
- user-data/token, basically it needs to be passed back in the callback, so app can correspond the tsx to something, just check
pjsip_endpt_send_request()orpjsua_call_make_call()for reference. - settings, it is for future use, must be NULL for now.
There was a problem hiding this comment.
Sorry..I misunderstood.
So you are saying that the token should already work and shouldn't be for future use cases, i e. that an object is allocated in the pool, which stores the acc_id and the token (a pointer). (In current PR only acc_id is stored).
|
Incorporated feedback in a fixup commit. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support of out-of-dialog transactions to PJSUA and PJSUA2. The requests are sent in the context of an account. The API is similar to that of an in-dialog transaction.
Example: The new interface can be used to send SIP OPTIONS.
Issue: #4156