Skip to content

Commit

Permalink
Get-DbaDbCheckConstraint: Add DatabaseId to the return object (datapl…
Browse files Browse the repository at this point in the history
  • Loading branch information
lancasteradam authored Oct 30, 2022
1 parent 636d5d4 commit 2ce2c86
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions functions/Get-DbaDbCheckConstraint.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ function Get-DbaDbCheckConstraint {
Add-Member -Force -InputObject $ck -MemberType NoteProperty -Name InstanceName -value $server.ServiceName
Add-Member -Force -InputObject $ck -MemberType NoteProperty -Name SqlInstance -value $server.DomainInstanceName
Add-Member -Force -InputObject $ck -MemberType NoteProperty -Name Database -value $db.Name
Add-Member -Force -InputObject $ck -MemberType NoteProperty -Name DatabaseId -value $db.Id

$defaults = 'ComputerName', 'InstanceName', 'SqlInstance', 'Database', 'Parent', 'ID', 'CreateDate',
'DateLastModified', 'Name', 'IsEnabled', 'IsChecked', 'NotForReplication', 'Text', 'State'
Expand Down
9 changes: 5 additions & 4 deletions tests/Get-DbaDbCheckConstraint.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ Write-Host -Object "Running $PSCommandPath" -ForegroundColor Cyan

Describe "$CommandName Unit Tests" -Tag 'UnitTests' {
Context "Validate parameters" {
[object[]]$params = (Get-Command $CommandName).Parameters.Keys | Where-Object {$_ -notin ('whatif', 'confirm')}
[object[]]$params = (Get-Command $CommandName).Parameters.Keys | Where-Object { $_ -notin ('whatif', 'confirm') }
[object[]]$knownParameters = 'SqlInstance', 'SqlCredential', 'Database', 'ExcludeDatabase', 'ExcludeSystemTable', 'EnableException'
$knownParameters += [System.Management.Automation.PSCmdlet]::CommonParameters
It "Should only contain our specific parameters" {
(@(Compare-Object -ReferenceObject ($knownParameters | Where-Object {$_}) -DifferenceObject $params).Count ) | Should Be 0
(@(Compare-Object -ReferenceObject ($knownParameters | Where-Object { $_ }) -DifferenceObject $params).Count ) | Should Be 0
}
}
}
Expand All @@ -34,11 +34,12 @@ Describe "$CommandName Integration Tests" -Tag "IntegrationTests" {
Context "Command actually works" {
It "returns no check constraints from excluded DB with -ExcludeDatabase" {
$results = Get-DbaDbCheckConstraint -SqlInstance $script:instance2 -ExcludeDatabase master
$results.where( {$_.Database -eq 'master'}).count | Should Be 0
$results.where( { $_.Database -eq 'master' }).count | Should Be 0
}
It "returns only check constraints from selected DB with -Database" {
$results = Get-DbaDbCheckConstraint -SqlInstance $script:instance2 -Database $dbname
$results.where( {$_.Database -ne 'master'}).count | Should Be 1
$results.where( { $_.Database -ne 'master' }).count | Should Be 1
$results.DatabaseId | Get-Unique | Should -Be (Get-DbaDatabase -SqlInstance $script:instance2 -Database $dbname).Id
}
It "Should include test check constraint: $ckName" {
$results = Get-DbaDbCheckConstraint -SqlInstance $script:instance2 -Database $dbname -ExcludeSystemTable
Expand Down

0 comments on commit 2ce2c86

Please sign in to comment.