When a content-length 0 gzipped file head request made, do not error out #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file, the request completes without exception - closes #19"
|
@pjfanning do you mind taking a look and let me know if any feedback. Thanks. |
|
@jbaranski I have a few things on so it might be a few days. Could you fix the scalafmt issues? @matsluni would you have time to check? Presumably if this is an issue, it also exists in your Akka focused lib. |
|
@pjfanning, I fixed the formatting issues so all your checks passed now, thanks! |
jbaranski
changed the title
|
Thanks - merged |
|
publishing 0.1.1 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
The AWS SDK expects SdkHttpFullResponse.content to be null/not present in the case there is no content, but this http client violates that contract.
In my sample project, you can use the built in HTTP client instead of this one, and everything works fine.