Fix #35: recursion error without Hover Editor

pjeby · Mar 16, 2022 · f1f2633 · f1f2633
1 parent 9dc5b4b
commit f1f2633
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/main.js b/main.js
diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
   "id": "quick-explorer",
   "name": "Quick Explorer",
-  "version": "0.1.16",
+  "version": "0.1.17",
   "description": "Perform file explorer operations (and see your current file path) from the title bar, using the mouse or keyboard",
   "minAppVersion": "0.13.23",
   "isDesktopOnly": true

diff --git a/src/FolderMenu.ts b/src/FolderMenu.ts
@@ -364,9 +364,11 @@ export class FolderMenu extends PopupMenu implements HoverParent {
     get hoverPopover() { return this._popover; }
 
     set hoverPopover(popover) {
-        if (this._popover && popover !== this._popover) {
-            this._popover.onHover = false;   // Force unpinned Hover Editors to close
-            this._popover.hide();
+        const old = this._popover;
+        if (old && popover !== old) {
+            this._popover = null;
+            old.onHover = false;   // Force unpinned Hover Editors to close
+            old.hide();
         }
         if (popover && !this.canShowPopover()) {
             popover.onHover = false;   // Force unpinned Hover Editors to close

diff --git a/versions.json b/versions.json
@@ -1,5 +1,5 @@
 {
-    "0.1.16": "0.13.23",
+    "0.1.17": "0.13.23",
     "0.1.9": "0.12.12",
     "0.0.5": "0.12.10",
     "0.0.1": "0.12.3"