Skip to content

Commit

Permalink
lib_manager: Add const to library manifest variable
Browse files Browse the repository at this point in the history
Added a const modifier to the module manifest variable in the
lib_manager_store_library function to prevent it from being accidentally
modified.

Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
  • Loading branch information
softwarecki authored and kv2019i committed Mar 13, 2024
1 parent 469c0a7 commit 7f2c789
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/library_manager/lib_manager.c
Original file line number Diff line number Diff line change
Expand Up @@ -689,11 +689,11 @@ static void __sparse_cache *lib_manager_allocate_store_mem(uint32_t size,
}

static int lib_manager_store_library(struct lib_manager_dma_ext *dma_ext,
void __sparse_cache *man_buffer,
const void __sparse_cache *man_buffer,
uint32_t lib_id)
{
void __sparse_cache *library_base_address;
struct sof_man_fw_desc *man_desc = (struct sof_man_fw_desc *)
const struct sof_man_fw_desc *man_desc = (struct sof_man_fw_desc *)
((__sparse_force uint8_t *)man_buffer + SOF_MAN_ELF_TEXT_OFFSET);
uint32_t preload_size = man_desc->header.preload_page_count * PAGE_SZ;
int ret;
Expand All @@ -711,7 +711,7 @@ static int lib_manager_store_library(struct lib_manager_dma_ext *dma_ext,

#if CONFIG_LIBRARY_AUTH_SUPPORT
/* AUTH_PHASE_FIRST - checks library manifest only. */
ret = lib_manager_auth_proc((__sparse_force void *)man_buffer,
ret = lib_manager_auth_proc((__sparse_force const void *)man_buffer,
MAN_MAX_SIZE_V1_8, AUTH_PHASE_FIRST);
if (ret < 0) {
rfree((__sparse_force void *)library_base_address);
Expand All @@ -721,7 +721,7 @@ static int lib_manager_store_library(struct lib_manager_dma_ext *dma_ext,

/* Copy data from temp_mft_buf to destination memory (pointed by library_base_address) */
memcpy_s((__sparse_force void *)library_base_address, MAN_MAX_SIZE_V1_8,
(__sparse_force void *)man_buffer, MAN_MAX_SIZE_V1_8);
(__sparse_force const void *)man_buffer, MAN_MAX_SIZE_V1_8);

/* Copy remaining library part into storage buffer */
ret = lib_manager_store_data(dma_ext, (uint8_t __sparse_cache *)library_base_address +
Expand Down

0 comments on commit 7f2c789

Please sign in to comment.