-
Notifications
You must be signed in to change notification settings - Fork 1
move to latest vercel version #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning Rate limit exceeded@piyush-jaiswal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 3 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughUpdated two GitHub Actions workflows to install the Vercel CLI using vercel@latest instead of a pinned version. No other steps or logic changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/deploy_preview.yml (1)
31-31
: Usingvercel@latest
in preview is fine; add traceability by logging the installed version.Preview jobs are a good place to surface breaking changes early. To aid debugging when “latest” changes upstream, print the resolved CLI version after install.
Apply:
- run: npm install --global vercel@latest + run: | + npm install --global vercel@latest + vercel --versionOptional (outside this hunk): pin the Node.js runtime so CLI behavior isn’t affected by a runner image update.
- name: Setup Node uses: actions/setup-node@v4 with: node-version: '20' # or your chosen LTS.github/workflows/deploy_production.yml (1)
29-29
: Pin Vercel CLI version in production workflowI ran a quick search across your workflows and confirmed that both deploy_production.yml (line 29) and deploy_preview.yml (line 31) currently install the Vercel CLI with
@latest
. For production, we should source a controlled version instead of floating onlatest
:• File: .github/workflows/deploy_production.yml
Replace:- run: npm install --global vercel@latest + run: | + VERSION="${{ vars.VERCEL_CLI_VERSION }}" + if [ -z "$VERSION" ]; then VERSION="latest"; fi + echo "Installing vercel@$VERSION" + npm install --global "vercel@$VERSION" + vercel --versionThis approach:
- Keeps the default behavior (
latest
) if you haven’t set VERCEL_CLI_VERSION.- Makes it trivial to pin or roll back by updating a single repo variable.
- Logs the exact version being used for traceability.
Preview can safely remain on
@latest
(or adopt the same pattern if you prefer consistency).Optional extra for determinism (both workflows):
- name: Setup Node uses: actions/setup-node@v4 with: node-version: '20' # pin your chosen LTSLet me know if you need a hand configuring the repo variable or updating the other workflow.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/deploy_preview.yml
(1 hunks).github/workflows/deploy_production.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: deploy-preview
e4ffb02
to
db50d29
Compare
Summary by CodeRabbit