-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING feature: preparing for Three.js r167 #1446
Merged
Merged
Commits on Jul 23, 2024
-
BREAKING feature: preparing for Three.js r167
import WebGPU / NodeMaterial stuff from `three/webgpu` See: mrdoob/three.js#28650 Three.js r167 is not released yet! I tested the behavior by using `yarn link` on `three` and `@types/three` importmaps for Three.js in webgpu examples are temporarily replaced to node_modules, please change them back before merging Some codes inside MToonNodeMaterial emit type errors because of recent @types/three changes I'm asking Methuselar96 why the change is made See: three-types/three-ts-types#1023 (comment)
Configuration menu - View commit details
-
Copy full SHA for 150d637 - Browse repository at this point
Copy the full SHA 150d637View commit details
Commits on Jul 26, 2024
-
package.json, readme, examples the build is failing
Configuration menu - View commit details
-
Copy full SHA for 92e9ef4 - Browse repository at this point
Copy the full SHA 92e9ef4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f40449 - Browse repository at this point
Copy the full SHA 5f40449View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5ff66c - Browse repository at this point
Copy the full SHA e5ff66cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e753d89 - Browse repository at this point
Copy the full SHA e753d89View commit details -
fix: Fix type of NodeMaterial members
See about the type assertion: three-types/three-ts-types#1123
Configuration menu - View commit details
-
Copy full SHA for 2f56a70 - Browse repository at this point
Copy the full SHA 2f56a70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7246089 - Browse repository at this point
Copy the full SHA 7246089View commit details -
fix: MToonLightingModel, Follow API change of LightingModel
`indirectDiffuse`, `indirectSpecular` are no longer interface functions, replaced by `indirect` - See: https://github.com/mrdoob/three.js/blob/4cc8fdfa944181c4274c91061574bcf033315bee/src/nodes/functions/PhysicalLightingModel.js#L510 - See: https://github.com/mrdoob/three.js/blob/4cc8fdfa944181c4274c91061574bcf033315bee/src/nodes/lighting/LightsNode.js#L102
Configuration menu - View commit details
-
Copy full SHA for d9abd77 - Browse repository at this point
Copy the full SHA d9abd77View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.