Move the redis tests to use containers from bazel #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zain Asgar <zasgar@pixielabs.ai>
JamesMBartlett
approved these changes
Mar 3, 2023
|
Overall changes look good, but can you do a final test run with |
|
RagalahariP
pushed a commit
to RagalahariP/pixie
that referenced
this pull request
Mar 23, 2023
Summary: Move the redis tests to use containers from bazel instead of pulling them from the registry. This allows the tests to run without internet access and not be subject to pull limits. This changes also removes some output assertions because redis does not always produce message when running outside of a terminal environemnt. The assertions aren't important for coverage since we check the test expectations as well. Relevant Issues: pixie-io#709 Type of change: /kind cleanup Test Plan: existing tests should pass. Signed-off-by: Zain Asgar <zasgar@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Move the redis tests to use containers from bazel instead of pulling them
from the registry. This allows the tests to run without internet access and not be subject to
pull limits.
This changes also removes some output assertions because redis does not always produce message when running outside
of a terminal environemnt. The assertions aren't important for coverage since we check the test expectations as well.
Relevant Issues: #709
Type of change: /kind cleanup
Test Plan: existing tests should pass.